os2forms_fordelingskomponent#1
Open
rimi-itk wants to merge 77 commits into
Open
Conversation
# Conflicts: # README.md
rimi-itk
force-pushed
the
os2forms_fordelingskomponent
branch
2 times, most recently
from
47e3fc9 to
90a075e
Compare
rimi-itk
force-pushed
the
os2forms_fordelingskomponent
branch
from
90a075e to
9c6d969
Compare
rimi-itk
force-pushed
the
os2forms_fordelingskomponent
branch
from
05192f8 to
8014267
Compare
rimi-itk
force-pushed
the
os2forms_fordelingskomponent
branch
from
8014267 to
8ccec62
Compare
rimi-itk
force-pushed
the
os2forms_fordelingskomponent
branch
4 times, most recently
from
27470cf to
5798ef9
Compare
rimi-itk
force-pushed
the
os2forms_fordelingskomponent
branch
from
5798ef9 to
fbba31e
Compare
rimi-itk
force-pushed
the
os2forms_fordelingskomponent
branch
2 times, most recently
from
85c21ca to
63c3a96
Compare
rimi-itk
force-pushed
the
os2forms_fordelingskomponent
branch
from
63c3a96 to
d3376a8
Compare
rimi-itk
force-pushed
the
os2forms_fordelingskomponent
branch
from
dd82b5c to
88fe36c
Compare
rimi-itk
force-pushed
the
os2forms_fordelingskomponent
branch
from
14710af to
3d59004
Compare
jekuaitk
requested changes
May 18, 2026
There was a problem hiding this comment.
Should these be placed in Selvbetjening examples
?
Comment on lines
+175
to
+180
| /** | ||
| * Create webform submission. | ||
| */ | ||
| private static function createWebformSubmission(array $values): array { | ||
| return $values; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Why? I understand that you hint at the function being the identity function, but we may want to do more stuff in the future and it makes sense to abstract that into a function – it's already called twice in the code!
…ngskomponent_examples.info.yml Co-authored-by: Jeppe Kuhlmann Andersen <78410897+jekuaitk@users.noreply.github.com>
Co-authored-by: Jeppe Kuhlmann Andersen <78410897+jekuaitk@users.noreply.github.com>
Co-authored-by: Jeppe Kuhlmann Andersen <78410897+jekuaitk@users.noreply.github.com>
rimi-itk
force-pushed
the
os2forms_fordelingskomponent
branch
from
65292b7 to
bac6e72
Compare
rimi-itk
force-pushed
the
os2forms_fordelingskomponent
branch
from
bac6e72 to
e6df9b4
Compare
jekuaitk
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The os2forms_fordelingskomponent module.